#6416 [Engine] serve: root the full-suite CI step at terminal/ so serve tests import

open · @MegaRushX · 0 commentaires · Sur GitHub

Server & APIDocumentation

Description

The Nov 17 layout move (4058aa782) put the server under `terminal/serve` and updated every path in this workflow, but the last step still discovered from the repo root:

```yaml
python -m unittest discover -s terminal/serve -p 'test_*.py'
```

`serve` tests import each other as `serve.<module>`, so with the root as the top-level directory (`serve` unknown), discovery collects the files and then fails to import them.

**Red, before (main's own push run on 3142b66b9):**
- https://github.com/Niko1221/Strata/actions/runs/44699738802 step "Run full server suite without terminal packages" exits non-zero.
- From the repo root locally: `Ran 264 tests ... FAILED (errors=156)`, every error an `ImportError ... from 'serve' (unknown location)`.
- The same step is red on my earlier #6315 head b7dbf93 (same job, same workflow) and on the current one, so it is not unique to one PR. Any PR whose paths touch `terminal/serve/**` runs this workflow.

**Green, after:**
- Run the step from `terminal/` and discover `-s serve`, which is how `docs/history/docs/work/IMPLEMENTATION_STATUS.md` runs the same suite.
- Locally from `terminal/`: discovery imports cleanly and the modules that failed at the root pass (`serve.test_yield_accounting` + `serve.test_parallel`: 55 tests OK). I started the full suite from the corrected root here but did not wait for it (>10 min in my sandbox); CI is the honest check.

**The change:** two lines in one step: `working-directory: terminal` and `-s terminal/serve` becomes `-s serve`.

I did not touch the earlier smoke step, any test file, or any other workflow. This is separate from #6315 on purpose: it is a repair to the gate, not to the code the gate was failing.

If you would rather express this as `PYTHONPATH: terminal` and keep the paths root-relative, close this and I will not re-push a variant.

Note: because this PR edits a workflow file, GitHub holds the new run at "action required" until a maintainer approves it. Expected, not a failure.

Sur le site

Liens install, modèles, releases.