#5812 [TUI] strata launch: moving the Access-step highlight makes an API key a local launch keeps
closed · @ackalker · 2 comentários · No GitHub
Setup & installServer & APIAMD / HIPModels & quantsSecurityWindowsLinux
Descrição
## Problem
On the `strata launch` **Access** step, pressing up/down to read the help text under each option runs a handler that *makes an API key* as soon as the highlight lands on any option beyond "This computer only". Nothing clears that key when the highlight goes back to "This computer only", so a launch that ends on localhost serves with a key - while the same screen says a key is not needed there.
`strata_cli/launch/screens.py:1556` (Access screen):
```python
def on_cursor(self) -> None:
kind = self.menu().current.key
s = self.ctx.settings
s.access = kind
if kind != "local" and not s.api_key and not s.no_key:
s.api_key = acc.kept_key() or acc.new_key()
```
`action_move` calls `on_cursor()` on every cursor move (`screens.py:192-197`), and so do `action_edge` (`:199-204`) and paging. `commit()` (`:1607-1611`) only *sets* a key for a non-local choice; it never clears one for a local choice. The only ways off are `t` (key toggle) or `--no-api-key` (`cmd.py:277-290`).
The key then follows the launch: `derive_config` writes it into the run config regardless of the access choice (`strata_cli/launch/runner.py:551-556`, `if s.api_key: cfg["api_key"] = s.api_key`), it is stored in the private launch preset (`settings.py:134` "stored only in the private preset file"), and `kept_key()` (`access.py:320`) hands it to later launches.
## Environment
**Strata Version:** 0.2.13 (engine 0.1.59), Terminal installed over a fresh desktop-app install
**OS:** Windows, Linux, macOS - the handler is platform-independent; the report below is from Linux
**Model/quant:** Qwen 3.8 Flash Next, IQ3_S (native pack)
## Reproduce
Reported from a real setup, exactly as the reporter worked:
1. Fresh install. The desktop app downloads Qwen 3.8 Flash Next IQ3_S, tunes it, chatting works.
2. Install the Terminal, run `strata launch`, and create a model preset.
3. On the Access step, move the highlight between the choices in order to read the help text below them.
4. Leave the highlight on "This computer only" and finish the launch.
5. Quit, then serve that model with `strata serve --profile <the profile the launch created>`.
6. Point a client (Pi) at the localhost address.
## Expected
No key: the help text on that very screen says "Only programs on this computer can reach it, so no key is needed." (`screens.py:1553`) and "This computer only is the safe default and never needs a key" (`:1496`). Outside the TUI the rule is the one expected here - a key is made only when `s.access != "local"` (`cmd.py:437-440`).
## Actual
The key made while browsing is kept, written into the run config and into the saved preset, and the server requires it. The client is refused:
```json
{"error": {"type": "authentication_error", "message": "missing or wrong API key"}}
```
(`serve/server.py:7867-7873`; the server takes the key straight from the config: `serve/server.py:10166-10176`, `strata_cli/cli.py:788-792`.)
Secondary, same handler: `on_cursor` also assigns `s.access = kind`, so moving the highlight to *read* a description changes the pending choice. Reading the help text is not a read-only action.
## Evidence
Function-level replay of the shipped logic (verbatim `on_cursor` + `commit` + the `derive_config` key lines, stubbed menu, fake key generator):
| cursor moves | `s.access` | `s.api_key` after | `cfg["api_key"]` |
|---|---|---|---|
| down to "Other computers" | lan | **set** | - |
| down to Tailscale | tailscale | set | - |
| up to "Other computers" | lan | set | - |
| up to "This computer only" | local | **still set** | - |
| commit, then derive_config | local | set | **written into the run config** |
Nothing in `tests/terminal` exercises `on_cursor`, `keytoggle` or `newkey` (`grep -rln "on_cursor\|keytoggle\|newkey" tests/terminal/*.py` is empty), so no test locks this as intended behaviour.
**Reproduction status:** the user workflow above was reproduced by the reporter in normal use. The code path is additionally confirmed here by reading the 0.2.13 source and by the function-level replay above; the full TUI was not driven in this checkout (Textual is not installed in its test environment).
## Suggested minimum fix
Make a key where the choice is acted on, not where the cursor rests: keep `on_cursor` to the help text, and let the TUI use the rule `cmd.py:437-440` already uses - make a key only at commit, and only when `s.access != "local"`. That also makes the local path byte-identical to `strata launch --access local`, which writes no key (`runner.py:551-556`).
## Related
#4396 (closed) fixed a different route to the same visible symptom - `strata launch` silently minting a new API key through `kept_key()` when a profile file could not be read. Different cause, same user-visible failure; this thread is about the Access screen's cursor handler.
No site
Links install, modelos, releases.